Repository navigation
ci: security scanning, with the findings read and justified - #32
Merged
Merged
Conversation
Calls security-scan.yml of keel-linux/.github (gitleaks, bandit, semgrep, shellcheck on hosted runners, no secrets) on pull requests, pushes to master and by hand. Not a required check. Baseline from a scan of master, none a risk. bandit B605 and semgrep's tainted-env rule on the same line: os.system of a constant shutdown command, prefixed by chvt $FGVT from confconsole's own environment, a root process. B104: WILDCARDS recognises a wildcard listen address, it binds nothing. B113: a request with no timeout can only hang the Let's Encrypt dialog. semgrep's insecure-file-permissions: only the execute bits of two root-owned scripts are toggled. Plus 15 shellcheck warnings of existing scripts. gitleaks: the WireGuard keys of two test files are fixtures, allowlisted by path in .github/gitleaks.toml.
marcos-mendez
force-pushed
the
ci/security-scan
branch
from
October 7, 2026 18:16
feddbc6 to
e7f886b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls security-scan.yml of keel-linux/.github (gitleaks, bandit,
semgrep, shellcheck on hosted runners, no secrets) on pull requests,
pushes to master and by hand. Not a required check.
Baseline from a scan of master, none a risk. bandit B605 and semgrep's
tainted-env rule on the same line: os.system of a constant shutdown
command, prefixed by chvt $FGVT from confconsole's own environment, a
root process. B104: WILDCARDS recognises a wildcard listen address, it
binds nothing. B113: a request with no timeout can only hang the
Let's Encrypt dialog. semgrep's insecure-file-permissions: only the
execute bits of two root-owned scripts are toggled. Plus 15 shellcheck
warnings of existing scripts.
gitleaks: the WireGuard keys of two test files are fixtures,
allowlisted by path in .github/gitleaks.toml.